[MPlayer-dev-eng] [PATCH] Crash in vf_spp.c and other things

[Diego Biurrun]

On Mon, Aug 28, 2006 at 10:06:05PM +0200, Gianluigi Tiesi wrote:
> > I'd be happy if someone implemented Michael's solution.  But some
> > encoding functions are necessary for other filters like vf_lavc for
> > example, which needs mpeg1 encoding capabilities.
> > 
> I known, vf_spp needs only to have fdct assigned that anyway is
> compiled in, a less invasive solution could be have fdct assignment
> in vf_spp.c, maybe if CONFIG_ENCODERS is not enabled, btw I don't see
> the problem of including 3-4 lines of code in dsputils_mmx.c with
> CONFIG_ENCODERS not enabled.
> vf_lavc could be excluded if CONFIG_ENCODERS is not enabled,
> I think most of users have a build with CONFIG_ENCODERS and
> they will not care about, but since the current solution
> is at least "hybrid", if someone wants vf_lavc he could
> always leaves encoder enabled.

Yes, I'm tempted to say that vf_lavc can be coupled with MEncoder
compilation.

> With a simple mod, we can have a working spp without having encoders,
> vf_lavc will needs anyway encoders.
> 
> I can make a patch, buy I'm not sure Michael wants to enable
> the code in dsputils_mmx.c (for me the more easy solution),
> so I can add runtime assignment e.g. in filter open()

Let's see your patch.

Diego