[MPlayer-dev-eng] [PATCH] Let vo directx survive screensaver

Zuxy Meng zuxy.meng at gmail.com
Mon Oct 30 02:17:43 CET 2006


Hi,

2006/10/29, Sascha Sommer <saschasommer at freenet.de>:
> Hi,
>
> On Sunday 29 October 2006 10:19, Reimar Döffinger wrote:
> > Hello,
> >
> > Patch here *g*
> >
>
> I do not like this patch. If I understand this correctly ( I'm not able to
> test at the moment ) locking will always fail when the screensave is on, no?
> With your patch vo directx will block for the whole time the screensaver is
> on. I do not see a reason why the audio shouldn't be playing in the
> background even though the screensaver is running, but then I thought we
> disable the screensaver somewhere in vo directx...
>
>
>
> Btw. in Zuxys patch
>
> @@ -679,7 +679,7 @@
>         dwUpdateFlags = DDOVER_SHOW | DDOVER_DDFX;
>         /*if hardware can't do colorkeying set the window on top*/
>                if(capsDrv.dwCKeyCaps & DDCKEYCAPS_DESTOVERLAY) dwUpdateFlags |=
> DDOVER_KEYDESTOVERRIDE;
> -        else vo_ontop = 1;
> +        else if (image) vo_ontop = 1;
>        }
>     else
>     {
>
> Why is this needed?

Without this line, when mplayer get recovered from screensaver, it'll
always be on top regardless of previous settings.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list