[MPlayer-dev-eng] [PATCH] fix configure check for NAS

[Bernd Ernesti]

On Sun, Sep 03, 2006 at 07:40:54PM +0200, Diego Biurrun wrote:
> On Sat, Sep 02, 2006 at 06:44:48PM +0200, Bernd Ernesti wrote:
> > 
> > Thank you. Now I need to find out why the X11 library directories are missing
> > while linking vidix/drivers.
> > 
> > >From config.mak:
> > 
> > EXTRA_LIB = -Wl,-z,noexecstack   -L/usr/X11R6/lib -Wl,-R/usr/X11R6/lib  -L/usr/pkg/lib -Wl,-R/usr/pkg/lib
> > X_LIB = -lGL  -lXxf86dga -lXv  -lXxf86vm -lXinerama  -lXext -lX11  -lpthread -Wl,-R
> > NAS_LIB = -laudio -lXt  -lXext -lX11  -lpthread -Wl,-R
> > 
> > It seems that $_ld_x11 is wrong for NetBSD.
> > Ah, I think I know why it fails, but have no idea how to fix it at the moment.
> > 
> > I use the following options for configure:
> > 
> > ./configure --prefix=/usr/pkg --with-extraincdir=/usr/X11R6/include/freetype2:/usr/pkg/include --with-extralibdir=/usr/X11R6/lib:/usr/pkg/lib --with-win32libdir=/usr/pkg/lib/win32 --with-reallibdir=/usr/pkg/lib/RealPlayer8-Codecs --disable-inet6 --disable-ftp --disable-xvid --disable-libcdio --enable-termcap
> > 
> > I need the extralib pointing to /usr/X11R6/lib to find the correct freetype library,
> > but this will cause a problem for this configure test:
> > 
> >   for I in $_ld_x11 "" -L/usr/X11R6/lib -L/usr/lib/X11R6 -L/usr/X11/lib \
> >            -L/usr/lib32 -L/usr/openwin/lib -L/usr/X11R6/lib64 -L/usr/lib ; do
> >     _ld_x11="$I -lXext -lX11 $_ld_sock $_ld_pthread"
> >     if netbsd; then
> >       _ld_x11="$_ld_x11 -Wl,-R`echo $I | sed s/^-L//`"
> >     fi
> >     cc_check $_ld_x11 && _x11=yes && break
> >   done
> > 
> > Note that it first checks for an empty $_ld_x11, so the test 'works' because
> > the extralibdir is allready including the X11 libarary directory.
> 
> Yes, and then it fails to make the changes in the netbsd special case.
> The problem is that this special case should not be there in the first
> place.  Please try to solve this in a more general fashion for NetBSD.

Sorry for following so late, but I didn't had time earlier to take a closer
look at the problem and sorry for the full quote above.

It is not the netbsd part which is the problem, it is that I specified the
x11 libraries with -with-extralibdir and so the _ld_x11 check worked in the
empty case "". So _ld_x11 ended up beeing empty and X_LIB didn't contain the
correct values.

I had another problem with a 'broken' freetype-config executeable, where the
enable_shared line was broken. This seems to be a problem with my X11 build,
but this is a different problem which shouldn't impact mplayer after I fixed it.

Right now I'm working on a patch to solve the freetype problem differently.
I will start a new thread with a patch for that problem.

Bernd