[MPlayer-dev-eng] [PATCH] CDDA configure fix/cleanup

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Oct 29 09:30:04 CET 2006


Hello,
attached patch cleans up cdda detection, currently cdda would be
displayed as both enabled and disabled by configure when libcdio is
used.
Okay to apply (testing would be a good idea, I do not have libcdio here)?

Greetings,
Reimar Döffinger
-------------- next part --------------
Index: configure
===================================================================
--- configure	(revision 20366)
+++ configure	(working copy)
@@ -5275,13 +5275,8 @@
 fi
 if test "$_cdparanoia" = yes ; then
     _cdda='yes'
-    _def_cdparanoia='#define HAVE_CDDA'
-    _inputmodules="cdda $_inputmodules"
     _ld_cdparanoia="$_ld_cdparanoia -lcdda_interface -lcdda_paranoia"
     openbsd && _ld_cdparanoia="$_ld_cdparanoia -lutil"
-else
-    _def_cdparanoia='#undef HAVE_CDDA'
-    _noinputmodules="cdda $_noinputmodules"
 fi
 echores "$_cdparanoia"
 
@@ -5313,9 +5308,7 @@
 if test "$_libcdio" = yes && test "$_cdparanoia" = no ; then
     _cdda='yes'
     _def_libcdio='#define HAVE_LIBCDIO'
-    _def_cdparanoia='#define HAVE_CDDA'
     _def_havelibcdio='yes'
-    _inputmodules="cdda $_inputmodules"
     _inc_extra="$_inc_extra `pkg-config --cflags libcdio`"
     _ld_libcdio=`pkg-config --libs libcdio_paranoia`
 else
@@ -5327,6 +5320,13 @@
 fi
 echores "$_libcdio"
 
+if test "$_cdda" = yes ; then
+    _def_cdparanoia='#define HAVE_CDDA'
+    _inputmodules="cdda $_inputmodules"
+else
+    _def_cdparanoia='#undef HAVE_CDDA'
+    _noinputmodules="cdda $_noinputmodules"
+fi
 
 echocheck "bitmap font support"
 if test "$_bitmap_font" = yes ; then


More information about the MPlayer-dev-eng mailing list