[MPlayer-dev-eng] [PATCH] False positive on pcm in mov samplerate hack

[Diego Biurrun]

On Thu, Sep 28, 2006 at 02:30:41PM -0400, John Koleszar wrote:
> 
> Attached patch fixes playback of a 5512Hz PCM audio track in a mp4 container
> when using the mov demuxer. The lavf demuxer plays the sample correctly.
> 
> demux_mov.c has some hackish code that thinks arbitrarily low sample rates
> (<7000) need to be adjusted. I can't find any samples that actually need the
> fixup, so I can't fix this properly. Does anybody know what this code is trying
> to work around? It's been in the tree practically forever.
> 
> Ripping the whole if() block out and fixing it Right once a broken sample is
> found is IMO a better option, but in the mean time here's a patch that tries to
> prevent these false positives.
> 
> Broken sample here:
> ftp://opensource:opensource@ftp.on2.com/5512hz_pcm.mov

This seems to be the relevant commit that added the 7000/8000 samplerate
special case:

http://svn.mplayerhq.hu/mplayer/trunk/libmpdemux/demux_mov.c?view=log#rev5213

"add alternative samplerate calculation for files with
timescale\!=samplerate"

Your patch works fine.  Comments, anyone?

Diego