[MPlayer-dev-eng] Re: [PATCH] vf_expand - clear left and right side of the image if needed

[Andrew Savchenko]

Hi!

On 22 Октябрь 2006 23:49 Reimar Döffinger wrote:
> Hello,
>
> On Sun, Oct 22, 2006 at 08:55:06PM +0200, Tomas Janousek wrote:
> > Reimar Döffinger napsal(a):
> > >How do you know if clearing them is needed? I wasn't really
> > > able to find a check for that in this patch (and I have no
> > > idea how to check this).
> >
> > Well, I just copied the code which does it for the top and
> > bottom and rewrote it. It worked for me, so I posted it, cos I
> > thought no one had ever needed it and since I had needed it, I
> > had written it.
>
> Oh, I think I completely misunderstood what the patch was
> supposed to do..
> Will try to have a closer look later

Well, this behaviour (not patch) is really needed and I'll try to 
explain why.

Suppose, you have a video wich doesn't fill all width of screen in 
the fullscreen mode, for examle, 700x600 video on the 4:3 monitor.
Try to find such video or make it with mencoder and do the 
following: 
1) go to full screen mode
2) switch to another application (using Atl+Tab in most desktops)
3) switch back to mplayer

And you will see bands (probably a part of the current screen on 
desktop) on the left and right side of the movie.

BUT, this patch doesn't fix this up! It must be reworked somehow...
Secondary, this patch doesn't apply to current svn and must be 
implemented manually.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061023/45fa6f1d/attachment.pgp>