[MPlayer-dev-eng] unneded? hack on vd_raw makes rgb16 fail [PATCH]

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Oct 22 10:54:57 CEST 2006


Hello,
On Sun, Oct 22, 2006 at 03:53:16AM -0300, Reynaldo H. Verdejo Pinochet wrote:
> Im here proposing the idea of simply remove this hack, patch attached
> , id happily (not really true) work on a cleaner fix ON THE AVI DEMUXER
> if this turns out to be needed for some (weird) sample out there and
> if and once someone provide such material.
> 
> going to commit unless someone has good reasons to do otherwise and
> a sample thats worth the ugly hack herein discussed.

I repeat again what I said on IRC: IMGFMT_BGR15 actually is 16 bpp,
unfortunate as it maybe, as each pixel allocates 16 bits of memory.
Otherwise IMGFMT_BGR32 would have to be 24 bpp, and the right solution
is to set sh->format in demux_lavf.c

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list