[MPlayer-dev-eng] [PATCH] subcp_recode changes

RC rcooley at spamcop.net
Tue Oct 17 04:53:00 CEST 2006


On Sun, 15 Oct 2006 10:47:38 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> 2) after failing to convert a line it will continue with the next
>    instead of not loading the subtitle at all. This may result in a
>    lot of "SUB: error recoding line." messages if -subcp is set wrong
>    but seems better to me than failing completely just because of one
>    bogus character.

I tried with several (wrong) -subcp values, and this patch appears to
work as described.

>    Somebody please test with an ogg file with included subtitles, I do
>    not have one. 

It doesn't break anything for me, and obviously works better than the
old code if an incorrect subcp is set.  Though I don't have any complex
subs to really test it.



More information about the MPlayer-dev-eng mailing list