[MPlayer-dev-eng] libdha vs PIC

[Diego Biurrun]

On Mon, Oct 16, 2006 at 05:50:17PM +0200, Reimar Döffinger wrote:
> Hello,
> On Mon, Oct 16, 2006 at 05:27:50PM +0200, Diego Biurrun wrote:
> > Umm, the gcc docs claim otherwise:
> 
> They can only speak about standard builds.
> 
> > http://gcc.gnu.org/onlinedocs/gcc-4.1.1/gcc/Code-Gen-Options.html
> > 
> > It only lists the options that are not the defaults and -fPIC is there.
> 
> Are you sure it's the same for e.g. hardened gentoo?

True.

> > The check for -fno-PIC was added as "Zeta OS support" by you.  So I
> > don't see what the problem will be with removing it again.  If Zeta
> > needs it, add a special case.
> 
> Well, maybe I'm just imagining things. Still, why would adding a special
> case for Zeta be a better solution than moving -fPIC at the end? Esp.
> since no-PIC _is_ a MPlayer requirement, unless things have much changed
> it will not compile with -fPIC, why is depending on gcc defaults that
> are completely outside our control the "cleaner" solution?

Moving -fPIC at the end has the drawback of overriding CFLAGS.  Thus if
you wish to disable PIC you need to edit the Makefile.  Passing CFLAGS
is not enough then.

Diego