[MPlayer-dev-eng] Bug: ao jack in libao2/ao_jack.c

[The Wanderer]

freacky22527 at free.fr wrote:

> With my version of jackd (0.100.0), mplayer always return the same
> error: "[JACK] cannot open server" but jackd il lauched and works
> perfectly with alsaplayer.
> So i made a patch to fix it :)

Please send patches in unified diff format (such as that produced by
default by 'svn diff'), and please attach them rather than pasting them
in the message body.

Also, what version of MPlayer's source code is this patch against? The
fact that the patch was not in unified diff format means that it was not
made via 'svn diff', which suggests that you are not running the latest
SVN version. Please send patches only against the latest SVN code.

There may or may not be other problems with your patch (does it break
compatibility with earlier versions of jackd? If so, do we need a
version check in configure, or is it okay to support only the latest
version? Are the linking options the same as before? If not, the patch
needs to add the necessary flags in configure.), but at the very least
the "unified diff" point needs to be addressed before the patch will be
seriously looked at.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.