[MPlayer-dev-eng] unneded? hack on vd_raw makes rgb16 fail

Reynaldo H. Verdejo Pinochet reynaldo at opendot.cl
Sat Oct 14 19:50:58 CEST 2006


Need some help here, turns out that this line on vd_raw.c:

// workaround bitcount==16 => bgr15 case for avi files:
case 16:
	sh->bih->biCompression=(sh->format)?IMGFMT_BGR16:IMGFMT_BGR15;
	break;

makes the lavf mtv demuxer unusable with mplayer, data (usually
16bpp rgb) gets treated as bgr15, is that correct? doesnt 
this hack (if needed) belongs to demux_avi ratter than vd_raw? 

I havent checked througly but i can imagine this is not only an rgb565
on mtv issue but a more general one. On libavcodec's raw demuxer
PIX_FMT for rgb colorspace gets chosen by looking at the bpp value,
there is no codec_tag/id for those (!sh->format) so either that hack 
gets reworked or i dont see how raw rgb16 data passed to libmpcodec's 
vd_raw trough ffmpeg's libavformat could posibly work.

Im a bit lost so any help would be really apreciated.

Best regards

	Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061014/66bcc832/attachment.pgp>


More information about the MPlayer-dev-eng mailing list