[MPlayer-dev-eng] [PATCH] double click to switch to full screen in GUI

[laurent wozniak]

Hello,

Diego Biurrun wrote:
> Grab the latest incarnation of the patch as posted by me and try to
> split it into self-contained independent pieces that can be discussed
> and applied separately.
>   
Here are the patches and a log that explain what they do.
Apart from the first one, they are all dependent on some other.
The apply order is of course from the first to the last.

Revisions are in the following format: (revision remote 19814 local 20059)
Remote revision (always 19814) correspond to MPlayer SVN.
Local revision (ex: 20059) correspond to my local SVK branch.
"log.log" or "log_verbose.log" gives the details of each patch (result 
of "svk log").


Some notes on how those patches were created:

I started to figure out how I could split a patch when pieces would be 
dependent on each other.
Doesn't sound to be possible ... for a scholar case.
The wise one said: "google is your friend".
Lucky was I, with all those buzz around BitKeeper and Linus I quickly 
find an interesting note on SVN website:
http://subversion.tigris.org/subversion-linus.html
I start learning the concepts of those next gen tools that could solve 
my problem.
They all share 2 key concepts: distributed architecture and local 
repositories.
Then I started testing some of them with the constraint of being able to 
mirror an SVN repository.
I choosed SVK since it is based on SVN and it's commands are quite 
similar to SVN.
I went to the standard SVN mirror case from the wiki and it worked.

So with a local mirror of MPlayer SVN and a local branch based on the 
revision of the original patch,
I could easily split the patch in pieces by commiting on my own branch.

I found this method quite nice when you have to do a big patch.
What do you think of it ?


Notes about the mouse wheels:

I did a lot more testing around the mouse wheels.
I also rewrite some parts to take into account the second horizontal 
wheel (due to a bug with the double click).

First, I discovered that my mouse has an hardware emulation for the 
second wheel when I tilt the wheel right or left.
I tested with the following X11 drivers:
- evdev (usb)
- mouse (usb)
- mouse (ps2)
The wheel behavior is consistent although some of the extra buttons are 
usually not recognized (but not always the same ones):
The mouse wheels send series of button events (press, release, press, 
release, ...).
I've also tested the behavior of mouse wheels and buttons in Firefox:
Wheels buttons (4,5,6,7) are bound to some actions (scroll, history) 
when the extra buttons just mimic the first one.
The (4,5,6,7) binding is also the default for the "mouse" driver.
So I think using the same button range for the 2 wheels is not a bad 
idea, it is at least consistent with some well known programs.

There is still a pending question: The original code is assuming some 
drivers are not sending mouse wheels button release events.
Do they really exists ?


Cheers,
Laurent
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20058.diff
Type: text/x-patch
Size: 703 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20059.diff
Type: text/x-patch
Size: 894 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20060.diff
Type: text/x-patch
Size: 830 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20061.diff
Type: text/x-patch
Size: 8835 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20062.diff
Type: text/x-patch
Size: 2024 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20063.diff
Type: text/x-patch
Size: 395 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20064.diff
Type: text/x-patch
Size: 1550 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20065.diff
Type: text/x-patch
Size: 2723 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20066.diff
Type: text/x-patch
Size: 7632 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20067.diff
Type: text/x-patch
Size: 1400 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: log.log
Type: text/x-log
Size: 2389 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: log_verbose.log
Type: text/x-log
Size: 3207 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061008/798ca82a/attachment-0011.bin>