[MPlayer-dev-eng] [PATCH] CoreAVC [3/5] - Win32

[Diego Biurrun]

On Thu, Oct 05, 2006 at 06:58:58AM -0700, Alan Nisota wrote:
> On 10/5/06, Diego Biurrun wrote:
> >> -static void* WINAPI expGetProcAddress(HMODULE mod, char* name)
> >> +static void* WINAPI expGetProcAddress(HMODULE mod, char *name)
> >> ...
> >> -       result=LookupExternalByName("kernel32.dll", name); break;
> >> +        result=LookupExternalByName("kernel32.dll", name); break;
> Are you saying you'll accept it once I fix these?

No, it just means that it's unacceptable in its current form.  I wrote
this as a general reminder for you to avoid cosmetics in future patches.

> I'm not going to do
> a bunch of cleanup if the patches are going to be rejected in the end
> anyway.  Overall, the reaction here has been very negative (which I
> can understand, I expected, and am fine with).  But I have better
> things to do than to beat a dead horse.

That's perfectly understandable.  Wait a bit more, further reviews of
your patches will probably be forthcoming.  Also, don't be discouraged
by negative comments.  It's customary for patches to go through several
revisions.

Diego