[MPlayer-dev-eng] [PATCH] CoreAVC [3/5] - Win32

[Guillaume Poirier]

Hi,

Alan Nisota wrote:
> On 10/5/06, Diego Biurrun wrote:
> 
>> > -static void* WINAPI expGetProcAddress(HMODULE mod, char* name)
>> > +static void* WINAPI expGetProcAddress(HMODULE mod, char *name)
>> > ...
>> > -       result=LookupExternalByName("kernel32.dll", name); break;
>> > +        result=LookupExternalByName("kernel32.dll", name); break;
> 
> Are you saying you'll accept it once I fix these?  I'm not going to do
> a bunch of cleanup if the patches are going to be rejected in the end
> anyway.  Overall, the reaction here has been very negative (which I
> can understand, I expected, and am fine with).  But I have better
> things to do than to beat a dead horse.


I don't have any opinion about whether of not it should be merged
(none of my main dev machines are likely to be supported by CoreAVC),
but I can say that so far, it looks like support of binary codecs has
only be added when no open source equivalent was available (such as
wmv3 videos, stuff like that).

This is clearly not the case of CoreAVC so I'd say it's "less likely"
that your patch gets accepted.
However, the development you had to do on the wine wrapper to make it
possible to use CoreAVC may be worth being merged if you manage to
provide clean patches...

Why is that? Well, maybe in the near future we'd want to add support
of a new closed-source/binary-only codec, which need the same kind of
development of wine wrapper.

just my 2c.

Guillaume