[MPlayer-dev-eng] [PATCH][RFC] ve_xvid4: make PSNR printing more consistent with other encoders

[Ivan Kalvachev]

2006/10/3, Guillaume POIRIER <poirierg at gmail.com>:
> Hi,
>
> On 10/3/06, Corey Hickey <bugfood-ml at fatooh.org> wrote:
> > Corey Hickey wrote:
> > > Hello,
> > >
> > > The attached patch makes the PSNR printing in ve_xvid4 look more
> > > consistent with the other encoders (mostly ve_lavc and ve_xvid).
> > > ------without the patch------
> > > xvid:     Min PSNR y : 35.68 dB, u : 40.13 dB, v : 41.10 dB, in frame 1
> > > xvid: Average PSNR y : 38.83 dB, u : 41.61 dB, v : 42.68 dB, for 142 frames
> > > xvid:     Max PSNR y : 42.39 dB, u : 44.05 dB, v : 44.96 dB, in frame 104
> > > -----------------------------
> > >
> > > (the wrapping above is from my mail client, not mencoder)
> >
> > Huh, I thought those lines would wrap, but it didn't.
> > ...
> > Anyway, does nobody object to me applying this?
> >
> > Ivan is the author of the original code, and I'd prefer to know if he
> > minds, but I don't see any messages from him that are less than a month
> > old, so I don't expect his feedback for now.
>
> :-)))))
> > If I don't hear any objections, I'll commit this in three days.
>
> I don't use XviD much these days, but I'm alright with your patch.
>
> So I'd say apply it whenever you feel like it.
>
> Guillaume

The original author of the code is GomGom from the xvid project, I
just committed the code and kept it up-to date.
If I remember right I think that I've done changes in the statistic,
as to show the "in frame <number>" to see how bad looks the worst psnr
frame.

You are free to commit your code whenever you like, just don't forget
to reply in this thread and say you did it.