[MPlayer-dev-eng] [PATCH] encode2mpeglight 0.6.0

Diego Biurrun diego at biurrun.de
Mon Oct 2 19:37:36 CEST 2006


On Mon, Oct 02, 2006 at 01:19:16PM -0400, Giacomo Comes wrote:
> the attached patch upgrades TOOLS/encode2mpeglight to the latest version.

Some comments about things I noticed while reading through the diff.
It's just spelling nitpicks, I didn't notice anything else apart from
the fact that many lines are horribly long and I'd prefer prefer you to
break them.  I'll apply an updated patch immediately.

> --- mplayer.ori/TOOLS/encode2mpeglight	2006-09-12 12:07:30.000000000 -0400
> +++ mplayer/TOOLS/encode2mpeglight	2006-10-02 13:05:57.000000000 -0400
> @@ -1,11 +1,11 @@
>  #
>  # Pourpose:         Convert anything MPlayer can play to AVI/VCD/SVCD/DVD mpeg

purpose, MPEG

> @@ -43,8 +43,8 @@
>  #   and more, consider to use the full release (http://encode2mpeg.sf.net)
>  #
>  #   encode2mpeglight is mainly tested with the stable release of MPlayer,
> -#   I try to make it work with CVS too, but due to the "instable" nature of
> -#   CVS, bugs may suddenly appear. If you find any, please report it to me.
> +#   I try to make it work with SVN too, but due to the "instable" nature of

unstable

> +#   SVN, bugs may suddenly appear. If you find any, please report it to me.

report them

> +    echo "$PROGNAME defaults to encode2mpeg's Mpeg Mode, the others mode are not"

MPEG, other modes

> @@ -189,7 +195,7 @@
>  ###############################################################################
>  #### variables initialization

variable

> +                do_log "++ WARN: [$PROGNAME] telecine only works for mpeg2, disabling it"

MPEG-2

> +    echo "  0) missing or mispelled input stream"

misSpelled ;-p

> @@ -1403,10 +1504,10 @@
>  fi
>  #### copy of non mpeg audio in a VCD

non-MPEG

Diego



More information about the MPlayer-dev-eng mailing list