[MPlayer-dev-eng] [PATCH] add support for all current and future x264 options

[Guillaume POIRIER]

Hi,

On 10/2/06, Loren Merritt <lorenm at u.washington.edu> wrote:
> On Sun, 1 Oct 2006, Guillaume POIRIER wrote:
>
> > Hi there,
> > Attached patch does $SUBJ. The doc part can be improved I imagine, but
> > I lack the technical background to do so.
>
> Counter proposal: libx264 already contains code to parse options
> symbolically, no need to duplicate it in mencoder.
> However, some of the older options didn't use the same names between
> mencoder and x264cli, so they would have to change.

Didn't you add synonym support to x264 a few minutes ago?

Maybe it's a stupid proposition, but could mencoder's options be added
to x264's parser as synonyms of x264 options?


> (documentation part not included.)

I can certainly take care of that part.


> Side-effect: if we do it this way, a failure to parse -x264encopts is a
> vf_open error rather than a parse error. vf_open errors aren't
> fatal, so it tries to continue encoding. This should be fixed anyway.

:-)

In any case, I certainly welcome the idea of using x264's parser to
remove the need to duplicate maintenance effort in MEncoder.


Guillaume