[MPlayer-dev-eng] memory leak because of missing demux_close_asf()

Aurelien Jacobs aurel at gnuage.org
Sun Oct 1 15:53:43 CEST 2006


On Sun, 01 Oct 2006 15:06:26 +0200
Burkhard Fischer <b.fi2 at web.de> wrote:

> Hi Guillaume,
> 
> I tested my patch against the current SVN version. The memory leak still 
> exists.

Please don't top-post.

> Here is my patch (svn diff output):
> 
> Index: libmpdemux/demux_asf.c
> ===================================================================
> --- libmpdemux/demux_asf.c	(revision 20011)
> +++ libmpdemux/demux_asf.c	(working copy)
> @@ -553,6 +553,8 @@
>       //---- ASF header:
>       if(!asf) return NULL;
>       if (!read_asf_header(demuxer,asf)) {
> +        if (asf->packet)
> +            free(asf->packet);
>           free(asf);
>           return NULL;
>       }

Inconsistent indentation (same applies to your whole patch).

Aurel



More information about the MPlayer-dev-eng mailing list