[MPlayer-dev-eng] [PATCH] localize with gettext (libintl)
Torinthiel
torinthiel at megapolis.pl
Wed Nov 29 23:59:24 CET 2006
And a few other remarks:
Splitting patches is good. Oversplitting is bad. There's no way that 58
patches are going to be considered. merge them in chunks of the same
functionality. Maybe send the help/*.h ones to MPlayer-DOCS, so
translators can review them, merge the ones to Makefile, configure,
mp_msg.* in one that can be reviewed as one piece.
Adding GT to all mp_msg calls is wrong, unless you have a way of testing
it. Much better would be to filter the text through gettext at beginning
of mp_msg, that way there's no possibility someone will forget this in
one place. And it reduces the number of patches significantly ;). I gnow
gettext manual won't advertise this, but gettext manual uses built-in
printf, not custom mp_msg you can alter.
Note, I might be completely wrong, I've just peeked at a few random
patches. 58 is way over my ability to start thinking. Esp. if they're so
intimately related.
Torinthiel
--
Waclaw "Torinthiel" Schiller GG#: 3073512
torinthiel(at)megapolis(dot)pl
gpg: 0906A2CE fpr: EE3E DFB4 C4D6 E22E 8999 D714 7CEB CDDC 0906 A2CE
"No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061129/fcc96cc1/attachment.pgp>
More information about the MPlayer-dev-eng
mailing list