[MPlayer-dev-eng] [PATCH] Avoid "_sleep deprecated" warning in cpuinfo.c

[Reimar Döffinger]

Hello,
On Wed, Nov 29, 2006 at 11:43:21PM +0100, Torinthiel wrote:
> On Wed, Nov 29, 2006 at 03:25:04PM -0500, Rich Felker wrote:
> > > > Why the hell would anyone need WINAPI, DWORD, etc.?? Just use the
> > > > proper names for these...
> > > 
> > > winbase.h needs them, so you can't use it directly.
> > 
> > typedef uint32_t DWORD;
> > #define WINAPI ...?
> > #include <winbase.h>
> 
> What's the difference between that and
> > -#define sleep(t) _sleep(1000*t);
> > +void __stdcall Sleep(unsigned);
> > +#define sleep(t) Sleep(1000*t);
> 
> as in first mail? Both do things that are in system headers. If the
> choice is between those two, I'd even vote for not including winbase,
> less clutter then.

I agree, such an effort to work around windows stupidity is not worth
it. I am for just including windows.h, because 1) that's how you're
supposed to do it I think 2) osdep/timer-win2.c already does it like
that, so we would at least have some consistency.

Greetings,
Reimar Döffinger