[MPlayer-dev-eng] Compiling with --enable-debug and --enable-profile

[Michael Niedermayer]

Hi

On Tue, Nov 28, 2006 at 02:50:57PM +0300, Dmitry Antipov wrote:
> Hello,
> 
> I've found that current SVN trunk can't be compiled with --enable-debug
> and --enable-profile on x86, mostly because a few inline assebmly bits
> can't be compiled with optimizations less than -O3 and without
> -fomit-frame-pointer. The patch included below is a minimal attempt to
> restore debugging/profiling build.
> 
> Dmitry
> 
> Index: mp3lib/sr1.c
> ===================================================================
> --- mp3lib/sr1.c	(revision 21349)
> +++ mp3lib/sr1.c	(working copy)
> @@ -411,7 +411,7 @@
> 
>      make_decode_tables(outscale);
> 
> -#ifdef CAN_COMPILE_X86_ASM
> +#if defined(CAN_COMPILE_X86_ASM) && !defined(MP_DEBUG)

--debug is not the same as compiling without fomit_frame_pointer
so this is rejected

adding a && !EBP_IS_SPECIAL to the affected code is the correct solution
similarely PIC should IMHO be replaced with EBX_IS_SPECIAL simply because
nothing besides gccs architecure prevents ebx from being used in asm in
PIC code

and -O0 could define GCC_O0 or such, but NEVER is the fact that 
-g / --enable-debug is used the correct condition 


[...]

> Index: libavcodec/cabac.h
> ===================================================================
> --- libavcodec/cabac.h	(revision 7178)
> +++ libavcodec/cabac.h	(working copy)

this is part of libavcodec -> patches belong to ffmpeg-dev

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is