[MPlayer-dev-eng] [PATCH] remove unused code from loader/stubs.S

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Nov 27 16:18:05 CET 2006


Hello,
unk_exp1 is currently unused, so I hereby suggest removing it.
Hopefully exp_EH_prolog can later be moved to inline asm, too.

Greetings,
Reimar Döffinger
-------------- next part --------------
Index: loader/stubs.S
===================================================================
--- loader/stubs.S	(revision 21327)
+++ loader/stubs.S	(working copy)
@@ -4,29 +4,6 @@
 # define SYM(x) x
 #endif
 	.data
-.LC0:	.asciz	"Called unk_%s\n"
-       .p2align 4
-.globl SYM(unk_exp1)
-SYM(unk_exp1):
-	pushl %ebp
-	movl %esp,%ebp
-	subl $4,%esp
-	movl $1,-4(%ebp)
-	movl -4(%ebp),%eax
-	movl %eax,%ecx
-	movl %ecx,%edx
-	sall $4,%edx
-	subl %eax,%edx
-	leal 0(,%edx,2),%eax
-	movl %eax,%edx
-	addl $SYM(export_names),%edx
-	pushl %edx
-	pushl $.LC0
-	call SYM(printf)
-	addl $8,%esp
-	xorl %eax,%eax
-	leave
-	ret
 .globl SYM(exp_EH_prolog)
 SYM(exp_EH_prolog):
 	pushl $0xff
Index: loader/win32.c
===================================================================
--- loader/win32.c	(revision 21327)
+++ loader/win32.c	(working copy)
@@ -5316,7 +5316,6 @@
 
 //static void add_stub(int pos)
 
-extern int unk_exp1;
 static int pos=0;
 static char extcode[20000];// place for 200 unresolved exports
 static const char* called_unk = "Called unk_%s\n";
@@ -5325,11 +5324,6 @@
 {
     // generated code in runtime!
     char* answ = (char*)extcode+pos*0x30;
-#if 0
-    memcpy(answ, &unk_exp1, 0x64);
-    *(int*)(answ+9)=pos;
-    *(int*)(answ+47)-=((int)answ-(int)&unk_exp1);
-#endif
     memcpy(answ, ext_stubs, 0x2f); // 0x2c is current size
     //answ[4] = 0xb8; // movl $0, eax  (0xb8 0x00000000)
     *((int*) (answ + 5)) = pos;


More information about the MPlayer-dev-eng mailing list