[MPlayer-dev-eng] [PATCH][RFC] video size change (realvideo)
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Nov 22 20:09:38 CET 2006
Hello,
On Wed, Nov 22, 2006 at 12:32:37AM +0100, Roberto Togni wrote:
Unrelated to this patch, but:
> Index: libmpcodecs/vf.c
> ===================================================================
> --- libmpcodecs/vf.c (revision 21115)
> +++ libmpcodecs/vf.c (working copy)
> @@ -318,12 +318,12 @@
> if(mpi->width!=w2 || mpi->height!=h){
> // printf("vf.c: MPI parameters changed! %dx%d -> %dx%d \n", mpi->width,mpi->height,w2,h);
> if(mpi->flags&MP_IMGFLAG_ALLOCATED){
> - if(mpi->width<w2 || mpi->height<h){
> +// if(mpi->width<w2 || mpi->height<h){
> // need to re-allocate buffer memory:
> free(mpi->planes[0]);
Isn't this broken? At least for direct rendering with OpenGL
mpi->planes[0] does _not_ point to malloced memory...
And I think this reallocating might actually be the (more) correct
solution than my proposal.
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list