[MPlayer-dev-eng] [PATCH] dvdnav part 3

Benjamin Zores ben at geexbox.org
Wed Nov 22 10:43:12 CET 2006


> Hi all!
>
> implemented:
> still and wait frames
> menu spu id
> audio id (partially)
> "simple menu box"

These are 4 features.
Can't this patch be splitted in 4 separated independant patches which
would be much easier to review and apply ?

Btw, you're still redefining max() and min() macros everywhere while they
already exist.

You did a great job with dvdnav support but you just need to do a bit more
to help us review them more easily.

Ben




More information about the MPlayer-dev-eng mailing list