[MPlayer-dev-eng] [PATCH] simplify tremor local diff

[Diego Biurrun]

On Sun, Nov 19, 2006 at 11:22:10PM +0100, Reimar Döffinger wrote:
> On Sun, Nov 19, 2006 at 11:05:03PM +0100, Diego Biurrun wrote:
> > The attached patch reverts most of our local modifications to tremor and
> > adds the missing header file from upstream.  Some testing on platforms
> > other than Linux is welcome, especially Windows.
> > 
> > I intend to apply this soon if there are no objections.
> 
> I am against this, the upstream version is extremely complicated and
> bloated

Nah, you're exaggerating now.  It's a bunch of nested #ifdefs, but this
is to be expected in a header that is designed to smooth over
os-dependent differences.

> I don't find it justified to add this back in just to reduce the diff.

I disagree.  I think the policy should be not to patch external
libraries for purely cosmetic reasons.  On the contrary, an attempt
should be made to minimize local changes.

Diego