[MPlayer-dev-eng] [PATCH] double click to switch to full screen in GUI

[Reimar Döffinger]

Hello,
On Sun, Nov 19, 2006 at 10:24:06PM +0100, laurent wozniak wrote:
> A couple of problems I've seen in this new patch:
> 
> * Major missing feature:
> - Does not work with the GUI, which is the purpose of this thread.

Well, as said one step after the other. Unless there is something that
would make it very hard to add GUI support that is no problem in itself.

> * Usability issue:
> - Double click is not mouse button (press, release, press, release)  but 
> (press, release, press).
> The double click event should not wait for the last button release to be 
> fired.
> This also explain why you have to be so fast in clicking with a timeout 
> set to 300.

Hm. Well, I think my last patch did not have this behaviour, I
specifically changed it. I found it a bit stupid that the sequence
(press, release, press, wait 2 second, release) would count as
double-click...

[...]
> Apart from this, I don't see how it could be possible to maintain the GUI
> since few people are interested in it and there is not that many maintainers
> to push in this part of the code.

In this case this has not much to do with the GUI, it just seems that
you and Diego seem to be about the only ones interested in that feature.

[...]
> My point is: How could I help with the GUI if there is nobody to review 
> my code,
> and therefore my patches vanish into the limbo of forgotten ?

They will not, but your patches try to solve all problems at once.
Splitting them has helped a lot, but they were almost all interdependent
and I had some doubts about usefulness or correctness of some parts.
Discussing multiple patches/issues, esp. interdepedent ones usually results
in endless discussions, too.
Unfortunately I am easily demotivated in such cases.
When there is one small patch after the other, the most obvious ones first
and preferably some other person also looking at it or at least testing,
things will most likely go much smoother.
But regardless, there are others with commit privileges, I still hope
one of them can be convinced to really care about this feature...

Greetings,
Reimar Döffinger