[MPlayer-dev-eng] De- and reactivate yadif

[Reimar Döffinger]

Hello,
On Sat, Nov 18, 2006 at 11:32:36AM +0100, Michael Niedermayer wrote:
> [...]
> > @@ -469,6 +472,21 @@
> >      return 0;
> >  }
> > 
> > +static int control(struct vf_instance_s* vf, int request, void* data){
> > +    switch (request){
> > +      case VFCTRL_GET_DEINTERLACE:
> > +        *(int*)data = do_deinterlace;
> > +        return CONTROL_OK;
> > +      case VFCTRL_SET_DEINTERLACE:
> > +        if (*(int*)data == -1)
> > +            do_deinterlace = !do_deinterlace;
> > +        else
> > +            do_deinterlace = *(int*)data;
> 
> set, get ok but do_deinterlace = !do_deinterlace; is redundant, considering
> that this would have to be added to every deinterlacing filter set(!get) at
> one central spot is better 

My fault, I suggested doing it like this. For some reason it seemed
nicer to me. I guess it was a misguided idea to avoid the overhead of
one extra control...

Greetings,
Reimar Döffinger