[MPlayer-dev-eng] BSD BT848 Radio interface (patch)

Diego Biurrun diego at biurrun.de
Sat Nov 18 02:42:14 CET 2006


On Thu, Nov 16, 2006 at 10:50:18PM +0600, voroshil at gmail.com wrote:
> Diego Biurrun wrote: 
> > > +  --disable-radio-bsdbt848)	_radio_bsdbt848=no	;;
> > 
> > The enable option is missing.
> This option was not missed. It is unuseful.
> It is unable to compile bsdbt848 without running autodetection
> block in configure (otherwise RADIO_BSDBT848_HDR value will not be set
> to required header and compilation will fail).

Please add it for consistency nevertheless.

> All other issues are fixed.
> Please review updated patch.

...

> --- configure	(revision 20962)
> +++ configure	(working copy)
> @@ -6749,10 +6752,33 @@
>  
> +if bsd && test "$_radio_bsdbt848" = auto && test "$_radio" = yes ; then
> +fi #if bsd && radio && radio_bsdbt848

Nit: Please use the same order in the comment as in the test above.

Commit.

Diego



More information about the MPlayer-dev-eng mailing list