[MPlayer-dev-eng] [PATCH] Filename double-conversion

Zuxy Meng zuxy.meng at gmail.com
Thu Nov 16 12:44:01 CET 2006


Hi,

2006/11/16, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
>
> The patch will change that anyway (note: the filename that is printed
> does not have to be valid, and esp. not < PATH_MAX). My argument is that
> if we add a limit, at least choose a sensible one and think of some way
> to handle the case when we hit the limit. PATH_MAX, even if available on
> all supported OS, is still quite unpredictable.
>

I see. Anyway no messsage longer than MSGSIZE_MAX will get fully
displayed. Maybe it can be implemented in mp_msg()?

> That AFAICT will make you patch massively more complicated. Unless you
> intend to malloc it but still have a fixed size. Then the only advantage
> would be clearing 4096 bytes less at startup.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list