[MPlayer-dev-eng] [PATCH] Filename double-conversion

Zuxy Meng zuxy.meng at gmail.com
Thu Nov 16 12:04:00 CET 2006


Hi,

2006/11/16, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On linux this is a full 4k, and I could easily expect that some systems
> might not have any limit at all, but at least one much larger.
> I would vote towards restricting this to something more like 512 bytes,
> and maybe just adding '...' if it was not possible to convert it fully

Well, that'll change the original behavior: without the patch the
filename gets printed as is no matter how long it is. If you're
concerned about the memory consumption, then recoded_filename can be
malloc'ed dynamically. But things'll be slowed down a bit....

> (i.e. filename_len != 0 after iconv). Well, I admit I'm not 100% certain this
> part is desirable.

As I said it'll benefit CJK users who use one of the legacy encodings
(GBK, Big5, or SJIS) the most. People who are either English-speaking
or using UTF-8 won't even feel the need.
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list