[MPlayer-dev-eng] [PATCH] audio channel remapping

[Reimar Döffinger]

Hello,
On Tue, Nov 14, 2006 at 04:27:59PM -0800, Corey Hickey wrote:
> I don't know if it can be simplified. I see a couple things that could 
> be different, but not necessarily better. In any case, the complexity of 
> (a) is centralized, versus being distributed into many separate files 
> (and only slightly lessened in most cases). Adding support to an 
> ad/ae/ao is much easier with my approach.

well, the complexity maybe centralized with the af approach, but it is
also far away from the real problem, probably making it even harder to
make a real fix.
I don't know. I think I mostly dislike inserting a filter, and that the
fix seems so far away from the problem. I wonder how complicated it
would be to instead create a reorder function that the ao/ad/aes can
use. Or at least in some other was encapsulate that new code in a
separate function instead of being "hidden" deep in the bowels of filter
chain creation.

> Have you looked at the patches for (b)? I don't seem to have provided a 
> link earlier.
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2006-October/046993.html

Yes, I did have a look. I tend towards slightly preferring them, but I
have not properly reviewed either.

Greetings,
Reimar Döffinger