[MPlayer-dev-eng] Re: [PATCH] Runtime Option to view the configure line used

Ivan Kalvachev ikalvachev at gmail.com
Tue Nov 14 00:30:15 CET 2006


2006/11/12, Brian Murray <brian at game-sat.com>:
>
> On 12-Nov-06, at 11:53 AM, Diego Biurrun wrote:
>
> > *Please* don't top post.
> >
> > On Sun, Nov 12, 2006 at 11:45:56AM -0700, Brian Murray wrote:
> >> Ok. Done. I still think a -configure-with is a good idea, but the -
> >> msglevel likely was overkill. Now it only displays with -v.
> >
> > This addresses only one part of my review, the info is not printed by
> > MEncoder now.  Also, it's not necessary to print the gcc version (much
> > less with ugly #ifdefs), that's already part of the version string.
> >
> > Diego
> >
> >> On 12-Nov-06, at 6:52 AM, Diego Biurrun wrote:
> >>
> >>> On Sat, Nov 11, 2006 at 07:52:29PM -0700, Brian Murray wrote:
> >>>> Ok. It responds to the -msglevel option of 'config', at level 5 and
> >>>> above.
> >>>>
> >>>> When bug reports are submitted, all= will catch them. Should
> >>>> help. :)
> >>>>
> >>>> It still responds to -configure-with. I think this is a
> >>>> necessity, as
> >>>> it makes it very simple for a user to pull out the configure line
> >>>> that was used, instead of digging through pages of output, or
> >>>> needing
> >>>> to learn the -msglevel syntax.
> >>>
> >>> This is overkill IMO.  MPlayer (and MEncoder) should just output
> >>> this
> >>> info in verbose mode, nothing more.
> >>>
> >>> Diego
> >>>
> >>> P.S.: Please don't top-post.
> > _______________________________________________
> > MPlayer-dev-eng mailing list
> > MPlayer-dev-eng at mplayerhq.hu
> > http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>
>
> Sorry about the top posting. I'm used to mailing lists that don't
> care. I also need to find a way to 'fix' my client.
>
> I added it to mencoder now, and removed the #ifdef's.

I'd like to ask for a feature of this feature.

When package maintainer uses -with- options and gives full path names,
including this info in the distributed binary could lead to a security
risk.
(attacker could find a way to inject file in that location that
eventually would end up in next version of mplayer package).

Please, find a nice way to avoid inclusion of this information, when
user wants to avoid it. (configure option to zero the string).



More information about the MPlayer-dev-eng mailing list