[MPlayer-dev-eng] [PATCH] encode2mpeglight 0.6.1

[Diego Biurrun]

On Mon, Nov 13, 2006 at 11:32:41AM -0400, Giacomo Comes wrote:
> On Mon, Nov 13, 2006 at 11:26:16AM -0400, Giacomo Comes wrote:
> > On Mon, Nov 13, 2006 at 12:37:36AM +0100, Diego Biurrun wrote:
> > > On Fri, Nov 10, 2006 at 04:23:52PM -0400, Giacomo Comes wrote:
> > > > the attached patch upgrades TOOLS/encode2mpeglight to the latest version.
> > > > Please apply. The old script does not work anymore with recent MPlayer.
> > > 
> > > Applied along with a bunch more spelling fixes.  I've bumped the version
> > > to 0.6.2 to reflect this.
> > 
> > Please keep the version number to 0.6.1 and if you make more changes add 
> > another subnumber. Consider the version I posted as 0.6.1.0 and keep increasing
> > the last digit. When I will post the new release it will be 0.6.2.0
> > 
> > > Why is the GPL header truncated?  Do you want to release under GPLv2
> > > only or is this just an oversight?
> > 
> > I don't understand what you mean. The header is the one reported here:
> > http://www.gnu.org/licenses/gpl-howto.html
> > What I did wrong?
> 
> May be you mean I didn't add the sentence "or (at your option) any later version".
> In that case the reason should be (if I remember correctly) that I wanted to see 
> what a later license says before including it.

I would personally add the "or later" clause, but this is entirely your
choice as the author.  The problem is that what you have now is
ungrammatical:

#   encode2mpeglight is free software; you can redistribute it and/or modify
#   it under the terms of the GNU General Public License as published by
#   the Free Software Foundation; either version 2 of the License.

Sentences that start with "either foo" should continue with "or bar".
This looks like the standard "or later" clause was just mistakenly
omitted.

If you wish to use just the GPLv2 (I would prefer v2+, but it's up to
you), write something like

#   encode2mpeglight is free software; you can redistribute it and/or modify
#   it under the terms of the GNU General Public License version 2 as
#   published by the Free Software Foundation.

Diego