[MPlayer-dev-eng] [PATCH] Filename double-conversion

[Zuxy Meng]

2006/10/31, Zuxy Meng <zuxy.meng at gmail.com>:
> Hi,
>
> 2006/10/30, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Hello,
> > On Mon, Oct 30, 2006 at 09:36:28AM +0800, Zuxy Meng wrote:
> > >  static iconv_t msgiconv;
> > > +static iconv_t inv_msgiconv = (iconv_t)(-1);
> > > +static char recoded_filename[MAX_PATH];
> > >  #endif
> >
> > Since they are only used there, IMHO move them into the function (of
> > course the static must stay).
>
> Well I just followed previous examples....
> >
> > > +const char* filename_recode(char* filename)
> >
> > Why is the parameter not const?
> >
> > > +    iconv(inv_msgiconv, (const char**)&filename, &filename_len,
> >
> > That cast seems useless to me, esp. if you change the parameter to
> > const.
>
> OK.

Reimar & Rich, still no comments for the modified version?

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6