[MPlayer-dev-eng] mmx.h license issues

[Aurelien Jacobs]

On Fri, 10 Nov 2006 01:12:00 +0100
Diego Biurrun <diego at biurrun.de> wrote:

> On Sun, Nov 05, 2006 at 03:12:18PM +0100, Diego Biurrun wrote:
> > Folks, over at Debian bug #396646 [1] somebody noticed that the file
> > trunk/mmx.h comes with a license statement that does not really permit
> > redistribution:
> > 
> >   THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY
> >   EXPRESS OR IMPLIED WARRANTIES, INCLUDING, WITHOUT
> >   LIMITATION, THE IMPLIED WARRANTIES OF MERCHANTABILITY
> >   AND FITNESS FOR ANY PARTICULAR PURPOSE.
> > 
> > This file is only needed by libmpcodecs/native/RTjpeg.c, so I think it
> > should not be in the root directory to begin with.  The file contains
> > some real code, not just definitions, meaning that it should really be
> > copyrightable to begin with.
> > 
> > We need to do something about this, but there are several options:
> > 
> > 1) Copy libavcodec/i386/mmx.h to libmpcodecs/native, it works.
> > 2) Put a smaller version of libavcodec/i386/mmx.h with just the
> >    necessary definitions in libmpcodecs/native.
> > 3) Make RTjpeg.c include libavcodec/i386/mmx.h.
> > 4) Finish porting to FFmpeg and remove RTjpeg.c.
> > 
> > Solution 3) would add a dependency on libavcodec to MPlayer, but this
> > should not be a big problem.  The ideal solution is 4), but 1) and 2)
> > are also workable.
> 
> I think I'll just put the attached header file in libmpcodecs/native.
> It's small and should thus be the simplest solution.

I'm not sure, but why not use C99 types such as int64_t instead of
long long in the mmx_t union ?

Aurel