[MPlayer-dev-eng] BSD BT848 Radio interface (patch)

Diego Biurrun diego at biurrun.de
Thu Nov 9 15:21:17 CET 2006


On Thu, Nov 09, 2006 at 08:17:06PM +0600, Vladimir Voroshilov wrote:
> 2006/11/9, Diego Biurrun <diego at biurrun.de>:
> >On Thu, Nov 09, 2006 at 07:36:17PM +0600, Vladimir Voroshilov wrote:
> >> I have made new version of bsdbt848 patch.
> >> Notes:
> >> Removed code related to mixer (currently, stream_radio's *_volume
> >> functions   control volume level
> >> of radio card only).
> >> Initialization of constants (frequency range and factor) moved to
> >> init_frac_bsdbt848.
> >>
> >> Please, anybody test it (i haven't bt848).
> >>
> >> --- stream/stream_radio.c     (revision 20812)
> >> +++ stream/stream_radio.c     (working copy)
> >> @@ -33,6 +33,22 @@
> >>  #include <sys/ioctl.h>
> >>  #include <errno.h>
> >>  #include <unistd.h>
> >> +
> >> +#ifdef HAVE_RADIO_BSDBT848
> >> +#include <sys/param.h>
> >> +#if defined(__DragonFly__)
> >> +#include <dev/video/meteor/ioctl_meteor.h>
> >> +#include <dev/video/bktr/ioctl_bt848.h>
> >> +#elif __FreeBSD_version >= 502100
> >> +#include <dev/bktr/ioctl_meteor.h>
> >> +#include <dev/bktr/ioctl_bt848.h>
> >> +#else
> >> +#include <machine/ioctl_meteor.h>
> >> +#include <machine/ioctl_bt848.h>
> >> +#endif
> >
> >This is very ugly.
> This code was got from stream/tvi_bsdbt848.c
> Suggestion?

Check for the headers in configure and then use a HAVE_XXX define.  Or
maybe even define the header name and then

#include BSD_RADIO_HEADER

or similar

Diego



More information about the MPlayer-dev-eng mailing list