[MPlayer-dev-eng] Re: [PATCH] Let vo directx survive screensaver

[Sascha Sommer]

Hi,

On Monday 06 November 2006 13:08, Zuxy Meng wrote:
> Hi,
>
> 2006/10/29, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Hello,
> >
> > On Sun, Oct 29, 2006 at 02:58:55PM +0800, Zuxy Meng wrote:
> > > No comments for this? IMHO it fixed a long-standing bug.
> >
> > I find it ugly. IMO image should not be null. What does vo_directx try
> > to do? Disable playback when the screensaver runs? If yes, just remove
> > that feature, I don't care if the video plays on to of the screensaver.
>
> flip_page() will fail to get a surface when screensaver runs, thus
> image will become zero. Dereferencing it results in segfault.

Did you test reimars patch?
The fewer workarounds get added the better.

Regards

Sascha