[MPlayer-dev-eng] [PATCH] Make disabling DPMS optional

[Paul TT]

On Fri, 3 Nov 2006 16:52:21 +0100
Holger Weiss <holger at CIS.FU-Berlin.DE> wrote:

> * RC <rcooley at spamcop.net> [2006-11-03 03:22]:
> > Holger Weiss <holger at CIS.FU-Berlin.DE> wrote:
> > > MPlayer disables DPMS on startup and re-enables it during exit (if
> > > DPMS was enabled in the first place); this behaviour is hardcoded.
> >
> > You can easily disable DPMS in config.h.  IMHO, it's not really
> > worth having a command-line option.
> 
> At least for us, an option would definitely be more convenient, as we
> wouldn't be forced to build MPlayer from source.  Also, the binary is
> exported to quite a few workstations via NFS and I'm not sure whether
> all users always want the same behaviour.
> 
> > In any case, I'd certainly pick better option names...  Perhaps
> > -(no)dpms ?
> 
> I thought about "-(no)dpms" myself, but found it a bit ambiguous: Does
> "-nodpms" mean "disable DPMS" or "don't disable DPMS"?  If you tell me
> which way round to do it, I'll send an updated pacth :-)

i read it this way:
no dpms to me means something like 'don't take care of dpms', so don't
disable. anyway i found totally useless to have the /true/ part, to let
mplayer disable it.
i think -nodpms, meaning 'don't take care of dpms is enough
MHO