[MPlayer-dev-eng] [RFC] split libmpdvdkit

[Diego Biurrun]

On Fri, Nov 03, 2006 at 06:52:17PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Friday, 03 November 2006 at 15:02, Diego Biurrun wrote:
> > On Mon, Oct 30, 2006 at 03:04:34PM +0100, Nico Sabbi wrote:
> > > Diego Biurrun wrote:
> > > 
> > > >I'd like to split libmpdvdkit into libdvdread and libdvdcss.  I think
> > > >the reasons for putting both libraries together are largely history 
> > > >
> > > I can't imagine one single good reason
> > > 
> > > >and
> > > >separating the libs should make upgrading and replacing them simpler.
> > > >At least the build system should get a bit simpler through this change.
> > > >
> > > >Removing libdvdcss while keeping our internal libdvdread would also
> > > >become easier.  We may not like this, but it's a reality that many
> > > >distributions unfortunately have to live with.
> > > >
> > > >Unless somebody convinces me this is a bad idea I plan to implement
> > > >this in the next week or so.
> > > >
> > > I like the idea.
> > > BTW, 1e10l to whomever merged the two in the first place
> > 
> > It's done.
> 
> Is there a reason to keep it in mplayer tree anymore? Many distros
> ship libdvdread anyway...

While our libdvdcss version is now vanilla, albeit a Subversion
snapshot, libdvdread is still patched.  I submitted our libdvdread
patches upstream some time ago, but they were not applied.  I might try
again one of these days unless somebody with more time beats me to it.

Also, we're still using an older version of libdvdread, 0.9.4, a patch
to upgrade to 0.9.5 was posted here, but it needs to be benchmarked
before it can be applied.

Diego