[MPlayer-dev-eng] [PATCH] SSA/ASS subtitles support

[陆然]

Hi,

On Saturday 06 May 2006 03:51, Evgeniy Stepanov wrote:
> Attached patch includes 2 major changes:
> - -vf ass=::x:y adds margins on top and bottom of the image, and places
> top- and subtitles there.
> - Karaoke support (\k, \kf, \K, \ko).
>
> How is the reviewing going ? This constant changes must be complicating it.
> Looks like pre8 is delayed, maybe its time to apply the patch ?

The patch has a minor problem with freetype 2.2.1, the prototype of 
FT_Stroker_New inftstroke.h has changed from  

FT_EXPORT( FT_Error ) FT_Stroker_New( FT_Memory memory, FT_Stroker 
*astroker );

to

FT_EXPORT( FT_Error ) FT_Stroker_New( FT_Library library, FT_Stroker *astroker 
);

So the code in the patch should be modified to be aware of the change.

And there is also an annoying bug with \fs{negative number}, I don't know if 
this is legitimate, but the tag will make the system almost hang. At least 
there should be some sanity check IMHO.

-- 
Best Regards,
LR