[MPlayer-dev-eng] [PATCH] forceaspect for vo_gl

[Reimar Döffinger]

Hi,
On Wed, May 24, 2006 at 08:33:10PM +0200, Tomas Janousek wrote:
> my windowmanager (fluxbox 0.1.14) for some reason doesn't honor the 
> aspect hint, so I added an option for the gl vo to force the aspect like 
> in fullscreen (by adding black borders). Is it acceptable?

For inclusion in CVS IMHO not, first because of the misuse of
aspect_save_screenres, second because if it is done, it should at least
be in a way that allows other vos to make use of this as well (since
they will have exactly the same problems), and I am a bit allergic to
such inconsistencies.
But apart from that I have to admit it might be desirable, esp. since
on e.g. windows the aspect hint AFAIK does not exist at all (though
there is another possible solution to this: Instead of adding black bars
you could manually aspect-adjust the size when you receive a
resize-event in x11_common.c, which has the advantage of working with
all X11 vos without extra work...).

Greetings,
Reimar Döffinger