[MPlayer-dev-eng] [PATCH 3/3] Provide some useful default for -vf expand

[Reimar Döffinger]

Hi,
On Tue, May 23, 2006 at 09:46:26PM -0700, RC wrote:
> On Wed, 24 May 2006 02:58:35 +0200
> Petr Baudis <pasky at ucw.cz> wrote:
> 
> > This patch will make -vf expand default to expanding the output
> > viewport height to make the viewport dimensions 4:3,
> 
> I _really_ don't like this idea at all...
> 
> Programs shouldn't guess what you want, it leads to lots of confusion. 
> And inserting vf expand without options might be useful in some
> situations, like debugging.

Agreed, if -vf expand is used regularly it can be set in the config file,
and if that is not flexible enough, making it possible to define per-filter
defaults in the config file would be the next step.
This IMHO is just a quick hack that may be great for the author but not
for inclusion in CVS.

Greetings,
Reimar Döffinger