[MPlayer-dev-eng] [PATCH 2/3] Support MPEG streams embedded ingeneric MOV tracks

[Nico Sabbi]

Petr Baudis wrote:
> This patch makes mplayer able to play MOV files containing generic track
> with a MPEG stream embedded by "hijacking" the MOV demuxer 

indeed: hijacked

> and replacing
> it with a MPEG demuxer (seeked at the appropriate point of the stream).
> The patch has been discussed on #mplayerdev.
>
> Such MOV files can be found e.g. on animemusicvideos.org (registration
> required, e.g. Ghibli - Rhythm of the Heat). I have uploaded an example
> file to incoming at ftp.mplayerhq.hu as EpisodeI.mov (or something like
> that) few days ago.
>
> The patch depends on the fact that there is only a single track in such
> a file, otherwise it emits an error message and ignores all but the first
> MPEG generic track. I have no idea if this situation could even arise
> in practice with any common MOV files, but I quite doubt it. mplayer
> current demuxer design seems to make it hard to support the generic case
> easily. :-(
> ---
>
>   

> +	// FIXME: Also honor trak->samples[0].size.
> +	demuxer->stream->start_pos = trak->samples[0].pos;
> +	// Hack from demux_rtp.c:
>   

no, when I told you to use demux_rtp.cpp as an example I wished you 
would use all
the block therein

> +	{
> +	// DEMUXER_TYPE_UNKNOWN? I don't know if there can't be other kinds
> +	// of MPEG here as well. --pasky
> +	demuxer_t* od = demux_open(demuxer->stream, DEMUXER_TYPE_MPEG_PS,
> +	                           audio_id, video_id, dvdsub_id, NULL);
> +	return new_demuxers_demuxer(od, od, od);
> +	}
> +    }
>  
>   

rejected. If you have to make it work so nastily you had better make 
mov_check_file()
return DEMUXER_TYPE_MPEG_PS; in alternative you can implement this patch 
properly
and build a proper linked demuxer
 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Per il tuo progetto da realizzare, Findomestic ti offre finanziamenti chiari e semplici senza anticipi
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=4967&d=24-5