[MPlayer-dev-eng] [PATCH] dvdnav - partial REVIEW

[James Courtier-Dutton]

Diego Biurrun wrote:
> On Thu, May 18, 2006 at 11:11:22PM +0200, Ötvös Attila wrote:
>> 2006. május 6. 18.59 dátummal Nico Sabbi ezt írta:
>>
>>> First of all: you added a directory with a scary name -libmpdvdnav-,
>>> that contains a modified version of libdvdnav. IMO this not
>>> acceptable; I wish that you could make your code work with the
>>> standard libdvdnav (importing still another projtect in mplayer is a
>>> serious problem: the sources tarball would grow even more and no one
>>> would fix/maintain it).
>> I think that your condition with libdvdnav killes the dvdnav patch that's why
>> if it can't use new libdvdnav functions then the dvd menu can't work a lot of
>> disks. I can promise you that I send my modify to libdvdnav developers:
>>
>> I wrote 13 Feb 21:51 (libdvdnav devel):
>> "I guess let's wait that the patch will be final. It is probable that we will 
>> be able to drop out more my functions."
>> http://blog.gmane.org/gmane.comp.video.libdvdnav.devel/month=20060201
> 
> Nico has a point, it would be best if you could cooperate with the
> upstream libdvdnav developers.  Adding libmpdvdnav is a possibility as
> well if that does not work out.
> 

What changes are being made to libdvdnav to get it to fit mplayer?
I project manage the libdvdnav project, so I would be interested to hear
what changes you have in mind. I might also have some helpful
suggestions if I knew what you were doing with it.
I had the impression that libdvdnav would require some considerable
rework to fit in well with mplayer architecture, but I never had time to
do the libdvdnav rework. Are you doing it for me? :-)

James