[MPlayer-dev-eng] [PATCH] dvdnav - partial REVIEW

Guillaume POIRIER poirierg at gmail.com
Mon May 22 14:49:15 CEST 2006


Hi,

On 5/22/06, Nico Sabbi <nsabbi at email.it> wrote:
> Diego Biurrun wrote:
> >>
> >> I think so #ifdef-ed MPDVDNAV can be removed if dvdnav patch replaces
> >> old functions and no expansion it. I would like to know if remove is in patch.
> >>
> >
> > Would it help if we ripped out the remnants of the old dvdnav support?
> > They are commented out in configure anyway and the code is dead.  You
> > would then have a clean base to build upon.
> >
> > Diego
> >
>
> at home I have a working dvdnav_stream.c. I restored only the stream
> reader, that is working
> quite well except for the seeking part.
> I'll post a patch tonight.

I tested Nico's patch this week-end. It allowed me to play a Sony DVD
which has some copy protection system which couldn't playback before.
Seeking indeed doesn't work with them, but VLC and xine do not do a
better job anyhow.

Guillaume
-- 
"Success consists of going from failure to failure without loss of enthusiasm."
  -- Winston Churchil



More information about the MPlayer-dev-eng mailing list