[MPlayer-dev-eng] Re: [PATCH] Various improvement in TOOLS/cpuinfo.c

[Zuxy Meng]

2006/5/16, Guillaume POIRIER <poirierg at gmail.com>:
> Hi,
>
> On 5/15/06, Zuxy Meng <zuxy.meng at gmail.com> wrote:
> > Hi,
> >
> > 2006/5/16, Guillaume POIRIER <poirierg at gmail.com>:
> > > Hi,
> > >
> > >
> > > Ok, good to know. The previous version (before last night) wasn't
> > > working on amd64 anyhow, so at least your patch fixes a known
> > > regression.
> > >
> > > I'm sure there's a way to support "macintel", amd64 and ia34...
> >
> > Will gcc define a macro like TARGET_64BIT under amd64?
>
> Maybe it does, I have not been able to find much information about it
> besides http://gcc.gnu.org/onlinedocs/gccint/Defining-Mode-Macros.html
> and http://gcc.gnu.org/onlinedocs/gccint/Examples.html
>
> The simplest way is probably to test on an amd64 machine.

Would please try __x86_64__? See if it's defined under amd64, and
undefined under x86 and amd64 with -m32.

>
> In any case, no need to worry, the patch you sent today works on AMD64
> (I just checked now as I'm home).
>

It might work, if the context use rbx as a 32 bit int; it mighty fail,
if the context use rbx as a 64 bit pointer. There's no guarantee
here:-(
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6