[MPlayer-dev-eng] [PATCH] warning fixes

[Dominik 'Rathann' Mierzejewski]

On Sunday, 14 May 2006 at 21:25, Dominik 'Rathann' Mierzejewski wrote:
> Hello.
> The first patch fixes the following:
> codec-cfg.c:1036: warning: pointer targets in passing argument 1 of ‘print_int_array’ differ in signedness
> codec-cfg.c:1039: warning: pointer targets in passing argument 1 of ‘print_int_array’ differ in signedness
> codec-cfg.c:1042: warning: pointer targets in passing argument 1 of ‘print_int_array’ differ in signedness
> codec-cfg.c:1048: warning: pointer targets in passing argument 1 of ‘print_int_array’ differ in signedness

> --- MPlayer-20060514/codec-cfg.c.warn	2006-04-03 21:41:14.000000000 +0200
> +++ MPlayer-20060514/codec-cfg.c	2006-05-14 20:24:25.000000000 +0200
> @@ -964,7 +964,7 @@
>          }
>  }
>  
> -static void print_int_array(const int* a, int size)
> +static void print_int_array(const unsigned* a, int size)
>  {
>  	printf("{ ");
>  	while (size--)

Can someone comment on this hunk?

Making it unsigned makes the use of abs() unnecessary, so
-            if(abs(*a)<256)
+            if(*a<256)

Should be there, too.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan