[MPlayer-dev-eng] [PATCH] warning fixes

Nico Sabbi nicola_sabbi at fastwebnet.it
Sun May 14 23:49:08 CEST 2006


Dominik 'Rathann' Mierzejewski wrote:

>Hello.
>The first patch fixes the following:
>codec-cfg.c:1036: warning: pointer targets in passing argument 1 of ‘print_int_array’ differ in signedness
>codec-cfg.c:1039: warning: pointer targets in passing argument 1 of ‘print_int_array’ differ in signedness
>codec-cfg.c:1042: warning: pointer targets in passing argument 1 of ‘print_int_array’ differ in signedness
>codec-cfg.c:1048: warning: pointer targets in passing argument 1 of ‘print_int_array’ differ in signedness
>subreader.c:1333: warning: assignment discards qualifiers from pointer target type
>dvbin.c:843: warning: assignment from incompatible pointer type
>ad_hwac3.c:115: warning: initialization from incompatible pointer type
>
>The second fixes printf format warnings.
>  
>
>  
>
[snip]

>--- MPlayer-20060514/libmpdemux/frequencies.h.warn	2006-04-03 21:41:20.000000000 +0200
>+++ MPlayer-20060514/libmpdemux/frequencies.h	2006-05-14 20:05:35.000000000 +0200
>@@ -107,5 +107,5 @@
> //extern struct STRTAB chanlist_names[];
> 
> extern int                chantab;
>-extern struct CHANLIST   *chanlist;
>+extern const struct CHANLIST *chanlist;
> extern int                chancount;
>--- MPlayer-20060514/libmpdemux/dvbin.c.warn	2006-05-13 21:41:33.000000000 +0200
>+++ MPlayer-20060514/libmpdemux/dvbin.c	2006-05-14 20:05:35.000000000 +0200
>@@ -778,8 +778,8 @@
> 	int i, fd, type, size;
> 	char filename[30], *conf_file, *name;
> 	dvb_channels_list *list;
>-	dvb_card_config_t *cards = NULL;
>-	dvb_config_t *conf = NULL, *tmp;
>+	dvb_card_config_t *cards = NULL, *tmp;
>+	dvb_config_t *conf = NULL;
> 	
> 	if(dvb_config != NULL)
> 		return dvb_config;
>  
>

ok to commit this one.
There's no need to ask permission before committing obviously correct 
fixes like this :)




More information about the MPlayer-dev-eng mailing list