[MPlayer-dev-eng] [BUG][PATCH] parsing of vobsub private data in mkv probably broken

[Evgeniy Stepanov]

On Sunday 14 May 2006 11:59, Moritz Bunkus wrote:
> this is definitely the right fix. demux_mkv_decode only decompresses at
> the moment, but the system might also be used for encryption. While
> decompressing usually yields bigger buffers decryption might not. In
> such cases (and even theoretically for decompression) we might end up
> with invalid memory accesses. As mplayer can play files from over the
> network... Well you get the picture.

Even when decoding gives bigger buffer, the current code is almost guaranteed 
to miss some subtitles ( demux_mkv_parse_idx function will only parse the 
starting portion of decoded data ).

Don't see any reason for not applying the fix.