[MPlayer-dev-eng] [PATCH] restore A/R change code in vd_ffmpeg.c

[Nico Sabbi]

Ivan Kalvachev wrote:

> 2006/5/12, Nico Sabbi <nicola_sabbi at fastwebnet.it>:
>
>>
>> I tested this patch on some sample without problems, so I'd like to know
>> if it's safe to
>> recommit it.
>>
>> Another doubt regards the sane aspect range:
>>  //     if(ctx->last_aspect>=0.01 && ctx->last_aspect<100)
>>
>> should this check be re-enabled, possibly extended to [0,100) ?
>
> Don't like including 0.
>
> Hum... there is a little problem with vd_ffmpeg aspect change.
> I'm the one that have disabled it because of the reason stated in the
> comment. Most decoders doesn't release&get_buffer on aspect change,
> and the re-inited vo could free the buffers. This is problem when
> init_vo called by get_buffer. Maybe we should check for aspect change
> only at get_format() .
>
> Anyway... ffmpeg12 does call get_foramt() and thus it must be safe. So
> the only test case(xvmc) that trigers problem is handled.
>

Michael, what's your opinion?